Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding tests for template websockets components #1351

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

test: adding tests for template websockets components #1351

wants to merge 6 commits into from
+134 −0

Conversation

DhairyaMajmudar
Copy link
Contributor

Description
Adding testing files for template websockets component: Requires and FileHeaderInfo

Related issue(s)
fixes: #1346, #1347, #1348

Tests are running file locally

Screenshots

Screenshot from 2025-01-30 01-39-43

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 982851b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DhairyaMajmudar DhairyaMajmudar changed the title Chore: Adding tests for template websockets components test: Adding tests for template websockets components Jan 29, 2025
@DhairyaMajmudar DhairyaMajmudar changed the title test: Adding tests for template websockets components test: adding tests for template websockets components Jan 29, 2025
derberg
derberg reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try writing tests without mocks included but reuse maybe https://github.com/asyncapi/generator/blob/master/packages/helpers/test/__fixtures__/asyncapi-websocket-query.yml like this: https://github.com/asyncapi/generator/blob/master/packages/components/test/components/models.test.js#L6

and then, if it works, that we "cross-use" fixtures between projects, maybe the file should be moved to a "generic" test fixtures folder

@DhairyaMajmudar
Copy link
Contributor Author

Updated the PR with suggested changes 👍🏻

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg left review comments

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create component test for existing components in the js websocket client
2 participants
@DhairyaMajmudar @derberg